Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schema): nested record shorthand type check #10449

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

samugi
Copy link
Member

@samugi samugi commented Mar 7, 2023

Summary

When a schema shorthand type check validation failed in a nested record, the error was not handled correctly, producing failures in setting the configuration that were hard to idenfity due to the missing error.

Checklist

Full changelog

  • [Implement ...]

Issue reference

Fix #[issue number]

KAG-851

@hbagdi hbagdi requested a review from bungle March 7, 2023 23:25
Copy link
Member

@gszr gszr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Please add a changelog entry (can be done in another PR)

@gszr gszr merged commit ea784c2 into master Mar 8, 2023
@gszr gszr deleted the fix/schema-adjust-context-error-handling branch March 8, 2023 19:06
samugi added a commit that referenced this pull request Mar 8, 2023
@samugi samugi mentioned this pull request Mar 8, 2023
1 task
bungle pushed a commit that referenced this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants